hpb/multi: properly split up internal.h based on backend #24224
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before this delta, internal.h looked like it's backend-agnostic. It's not; it relied too heavily on upb internals. This CL sunders that illusion. The extant internal.h has been moved to hpb/backend/upb, and a dummy c++ corollary has been created in hpb/backend/cpp. PiperOrigin-RevId: 825088652
copybara-service
bot
force-pushed
the
test_825088652
branch
from
e59cc1d to
ab6c256
Compare
|
Auto-closing Copybara pull request |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hpb/multi: properly split up internal.h based on backend
Before this delta, internal.h looked like it's backend-agnostic. It's not; it relied too heavily on upb internals. This CL sunders that illusion.
The extant internal.h has been moved to hpb/backend/upb, and a dummy c++ corollary has been created in hpb/backend/cpp.